[15.0] sale_commission_formula: Migration to 15.0 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
15.0-mig-sale_commission_formula
branch
from
6566dbe to
e026a5a
Compare
|
Hi @AungKoKoLin1997 will you continue with the migration? THX |
Yes. The migration of commission modules are done. So, I am planning to work on these days. |
THX! |
- Remove onchange hackings as they are not needed with new JS views. - Extract common code between sales orders and invoices, creating 2 mixins. - Adapt tests. - Improve README with detailed explanations. - README by fragments. - Changed `settled` condition to a more suitable one, moving the condition to _skip_settlement. - Improve interface for not removing editable option in lines: you have a new icon that popups a window with agents. This icon is available according certain conditions. Check README for more details. - Add constraint for avoiding the modification of a settled commission. - Add agent values when no other value is provided. This way, we add compatibility with modules like `sale_product_set` or `sale_order_variant_mgmt`.
* Add description to all models * Adapt commission amount computation courtesy of Simone Rubi * Adapt views * Fixed dependencies in constraint
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/ [UPD] Update sale_commission_formula.pot [UPD] README.rst
Currently translated at 95.2% (20 of 21 strings) Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/it/
Currently translated at 100.0% (21 of 21 strings) Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/zh_CN/
Currently translated at 61.9% (13 of 21 strings) Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/pt/
Currently translated at 100.0% (21 of 21 strings) Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/pt_BR/
Currently translated at 85.7% (18 of 21 strings) Translation: commission-12.0/commission-12.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-12-0/commission-12-0-sale_commission_formula/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-13.0/commission-13.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_formula/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-13.0/commission-13.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_formula/ [UPD] Update sale_commission_formula.pot
Currently translated at 100.0% (19 of 19 strings) Translation: commission-13.0/commission-13.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-13-0/commission-13-0-sale_commission_formula/es_AR/
Currently translated at 85.7% (12 of 14 strings) Translation: commission-14.0/commission-14.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_formula/it/
Currently translated at 100.0% (14 of 14 strings) Translation: commission-14.0/commission-14.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_formula/it/
Currently translated at 100.0% (14 of 14 strings) Translation: commission-14.0/commission-14.0-sale_commission_formula Translate-URL: https://translation.odoo-community.org/projects/commission-14-0/commission-14-0-sale_commission_formula/pt_BR/
AungKoKoLin1997
force-pushed
the
15.0-mig-sale_commission_formula
branch
2 times, most recently
from
e481014 to
5476d90
Compare
|
@HaraldPanten Can you please review this PR? |
Sure! |
|
/ocabot migration sale_commission_formula |
|
The migration issue (#328) has been updated to reference the current pull request. |
pedrobaeza
reviewed
Dec 28, 2022
AungKoKoLin1997
force-pushed
the
15.0-mig-sale_commission_formula
branch
from
bcfc1d0 to
b9242ee
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 19c0c96. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.