[18.0][MIG] commission + rename to commission_oca #610

JordiMForgeFlow · 2025-04-22T08:04:54Z

Supersedes #602 due to inactivity

sale_commission will need to be renamed to sale_commission_oca (#605), so we could rename the base module to commission_oca for alignment.

CC @alan196

- Make specific top-level menu and permissions for commissions. - Don't depend on account. - Reorganize elements. - Change some parts of the code to fit better ORM tools. - Adjust permissions in children modules. - Add <sheet> to some form views to get modern view.

This way, we can restrict which commissions we can select or be automatically populate in the different documents.

Currently translated at 53.7% (57 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

Currently translated at 61.3% (65 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

Currently translated at 100.0% (106 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

JasminSForgeFlow

LGTM!

JordiMForgeFlow · 2025-04-28T07:00:20Z

@sebalix could we get your input in this one?

sebalix

Don't know well this module, but from a technical POV it loogs good. I agree on the renaming too.

For info Odoo EE is proposing the following module technical names:

partner_commission
sale_commission
sale_commission_margin
sale_commission_subscription

pedrobaeza · 2025-04-28T07:33:12Z

/ocabot migration commission

Thanks for the migration and the renaming. I'm afraid the renaming you have done doesn't include the whole commit history, so on the next version, only the last commit will be rescued with the procedure.

For avoiding this, you have to rename the whole history, please execute the following commands in your branch:

git filter-branch --tree-filter 'if [ -d commission ]; then mv commission commission_oca; fi' HEAD
git rebase origin/18.0
git push -f

and it will be done for the whole commit history.

Another thing: for the PO/POT, you have to also rename the module on each translation string comment.

commission_oca/i18n/it.po

OCA-git-bot · 2025-04-28T07:53:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

JordiMForgeFlow · 2025-04-28T08:23:34Z

@pedrobaeza it should now be ready :) thank you!

pedrobaeza

Thanks!

/ocabot merge nobump

OCA-git-bot · 2025-04-28T10:00:49Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-610-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-28T10:04:53Z

Congratulations, your PR was merged at 511450f. Thanks a lot for contributing to OCA. ❤️

MiquelRForgeFlow · 2025-04-28T10:18:38Z

Shouldn't be done anything in OpenUpgrade?

pedrobaeza · 2025-04-28T10:20:30Z

Yes, the renaming should happen also in OpenUpgrade, so you can proceed with the PRs. Thanks for being aware.

AungKoKoLin1997 and others added 30 commits April 22, 2025 09:57

[MIG] sale_commission: Migration to 15.0

95d62bb

[IMP] commission*: Add settlement_type to commissions

5b362f8

This way, we can restrict which commissions we can select or be automatically populate in the different documents.

[UPD] Update commission.pot

67cd980

[UPD] README.rst

065e9de

commission 15.0.2.0.0

5f534d1

Added translation using Weblate (Japanese)

56bda51

Translated using Weblate (Japanese)

eef4d8b

Currently translated at 53.7% (57 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

Translated using Weblate (Japanese)

d7840f2

Currently translated at 61.3% (65 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

Translated using Weblate (Japanese)

67efe7f

Currently translated at 100.0% (106 of 106 strings) Translation: commission-15.0/commission-15.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-15-0/commission-15-0-commission/ja/

[MIG] commission: Migration to 16.0

838e65c

[IMP] commission: Align dates in settlement view

f067e05

[UPD] Update commission.pot

780191b

[UPD] README.rst

e6b8a06

Update translation files

cf75820

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

[UPD] Update commission.pot

7f766b4

Update translation files

203bb46

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

[UPD] Update commission.pot

d008fb6

Update translation files

c87d1e5

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

[FIX] commission: Show full settlements table in partner

e40acbf

commission 16.0.1.1.0

4a9fa22

[IMP] commission: Default commission_free instead of related

0489276

commission 16.0.1.1.1

cbd3b45

[IMP] commission: use mail thread and improve report

9d71d33

[UPD] Update commission.pot

c0bce70

commission 16.0.1.2.0

cea5563

Update translation files

65cd702

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

[UPD] README.rst

fbc2db7

[UPD] Update commission.pot

306545c

Update translation files

a6e95d7

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: commission-16.0/commission-16.0-commission Translate-URL: https://translation.odoo-community.org/projects/commission-16-0/commission-16-0-commission/

JasminSForgeFlow approved these changes Apr 23, 2025

View reviewed changes

sebalix approved these changes Apr 28, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 28, 2025

pedrobaeza mentioned this pull request Apr 28, 2025

[18.0] [MIG] commission: Migration to 18.0 #602

Closed

OCA-git-bot added this to the 18.0 milestone Apr 28, 2025

OCA-git-bot mentioned this pull request Apr 28, 2025

Migration to version 18.0 #564

Open

6 tasks

JordiMForgeFlow force-pushed the 18.0-mig-commission branch from 5254d50 to 28c1f7d Compare April 28, 2025 07:46

pedrobaeza reviewed Apr 28, 2025

View reviewed changes

commission_oca/i18n/it.po Outdated Show resolved Hide resolved

OCA-git-bot added the ready to merge label Apr 28, 2025

JordiMForgeFlow force-pushed the 18.0-mig-commission branch from 28c1f7d to 38eb67c Compare April 28, 2025 08:02

JordiMForgeFlow mentioned this pull request Apr 28, 2025

[18.0] [MIG] account_commission: Migration to 18.0 #582

Closed

[MOV] commission: rename to commission_oca

cc0eede

JordiMForgeFlow force-pushed the 18.0-mig-commission branch from 38eb67c to cc0eede Compare April 28, 2025 08:19

sebalix mentioned this pull request Apr 28, 2025

[IMP] Add support for module renaming OCA/oca-port#74

Draft

8 tasks

pedrobaeza approved these changes Apr 28, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Apr 28, 2025

OCA-git-bot merged commit 4587c5c into OCA:18.0 Apr 28, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 28, 2025

JordiMForgeFlow mentioned this pull request Apr 28, 2025

[18.0][MIG] account_commission + rename to account_commission_oca #611

Merged

MiquelRForgeFlow deleted the 18.0-mig-commission branch April 28, 2025 10:18

MiquelRForgeFlow mentioned this pull request Apr 29, 2025

[18.0][IMP] apriori: commission -> commission_oca OCA/OpenUpgrade#4962

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] commission + rename to commission_oca #610

[18.0][MIG] commission + rename to commission_oca #610

Uh oh!

JordiMForgeFlow commented Apr 22, 2025 •

edited

Loading

Uh oh!

JasminSForgeFlow left a comment

Uh oh!

JordiMForgeFlow commented Apr 28, 2025

Uh oh!

sebalix left a comment

Uh oh!

pedrobaeza commented Apr 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

JordiMForgeFlow commented Apr 28, 2025

Uh oh!

pedrobaeza left a comment

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

MiquelRForgeFlow commented Apr 28, 2025

Uh oh!

pedrobaeza commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

[18.0][MIG] commission + rename to commission_oca #610

[18.0][MIG] commission + rename to commission_oca #610

Uh oh!

Conversation

JordiMForgeFlow commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JasminSForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

JordiMForgeFlow commented Apr 28, 2025

Uh oh!

sebalix left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Apr 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

JordiMForgeFlow commented Apr 28, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

MiquelRForgeFlow commented Apr 28, 2025

Uh oh!

pedrobaeza commented Apr 28, 2025

Uh oh!

Uh oh!

JordiMForgeFlow commented Apr 22, 2025 •

edited

Loading