Skip to content

[16.0][IMP] delivery_package_number: shortend delivery_package_number document height #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2025
Merged

[16.0][IMP] delivery_package_number: shortend delivery_package_number document height #1006

merged 1 commit into from
Apr 2, 2025

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Apr 2, 2025 •
edited
Loading

There are cases when a address is too big and it overflows to having 2 pages, when it only should have one.

This PR reduces the box vertical padding to fix that

After
image

Before
image

I-7193

@Tisho99 Tisho99 changed the title [IMP] delivery_package_number_label: shortend delivery_package_number document height [16.0][IMP] delivery_package_number_label: shortend delivery_package_number document height Apr 2, 2025
@Tisho99 Tisho99 force-pushed the 16.0-imp_delivery_package_number_label branch from e91c51c to 2dc441d Compare April 2, 2025 10:57
@Tisho99
Copy link
Contributor Author

Tisho99 commented Apr 2, 2025

@HaraldPanten @ValentinVinagre @Jaimermaccione

@Tisho99
Copy link
Contributor Author

Tisho99 commented Apr 2, 2025

Good morning @adasatorres

This PR fixes your additions in #939, when the address is too big

Maybe you are interested

@Tisho99
Copy link
Contributor Author

Tisho99 commented Apr 2, 2025

Hello @rlizana @sergio-teruel

This PR continues other you took part in: #927

Maybe you are interested

@HaraldPanten
Copy link

@pedrobaeza Do you mind having a look at this, please?

@rousseldenis rousseldenis added this to the 16.0 milestone Apr 2, 2025
rousseldenis
rousseldenis approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Functionally tested

ValentinVinagre
ValentinVinagre approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1006-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c6114b2 into OCA:16.0 Apr 2, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e356bc7. Thanks a lot for contributing to OCA. ❤️

@ValentinVinagre ValentinVinagre deleted the 16.0-imp_delivery_package_number_label branch April 2, 2025 14:37
@ValentinVinagre
Copy link
Contributor

@Tisho99 The same thing happens in v17 and does the same fix have to be implemented?

@Tisho99
Copy link
Contributor Author

Tisho99 commented Apr 2, 2025

@ValentinVinagre

I can do a FW port, give me some time and I'll do it

@ValentinVinagre
Copy link
Contributor

@ValentinVinagre

I can do a FW port, give me some time and I'll do it

No problem, it's to confirm if we would have to transfer it, there's no problem if it takes 1 week.

@Tisho99 Tisho99 changed the title [16.0][IMP] delivery_package_number_label: shortend delivery_package_number document height [16.0][IMP] delivery_package_number: shortend delivery_package_number document height Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@ValentinVinagre ValentinVinagre ValentinVinagre approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

Assignees
No one assigned
Labels
approved enhancement merged 🎉 needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Tisho99 @HaraldPanten @pedrobaeza @OCA-git-bot @ValentinVinagre @rousseldenis