Skip to content

[15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users #1337

wants to merge 1 commit into from

Conversation

ppyczko
Copy link

@ppyczko ppyczko commented Mar 7, 2025 •
edited
Loading

The FSM Orders button wasn't visible in the Sale Order view for group_fsm_user_own users.
This [IMP] makes the button accessible, aligning it with the group's access rights.

cc https://github.com/APSL 3553

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review

@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@ppyczko ppyczko marked this pull request as ready for review March 7, 2025 07:15
@ppyczko ppyczko changed the title [IMP] fieldservice_sale: Show FSM Orders button for own documents users [15.0][IMP] fieldservice_sale: Show FSM Orders button for own documents users Mar 7, 2025
mpascuall
mpascuall approved these changes Mar 7, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

peluko00
peluko00 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@mpascuall mpascuall mpascuall approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppyczko @OCA-git-bot @peluko00 @mpascuall