Skip to content

[17.0][IMP] fieldservice: Added filter Due This Week #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][IMP] fieldservice: Added filter Due This Week #1347

wants to merge 1 commit into from

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Mar 13, 2025 •
edited
Loading

This PR introduces a filter on fsm_order to display orders that are scheduled for completion within the current week (from Monday to Sunday). The filter ensures that only orders with a scheduled_date_start within this week are shown.

cc https://github.com/APSL 4230

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

@OCA-git-bot
Copy link
Contributor

Hi @brian10048, @max3903,
some modules you are maintaining are being modified, check this out!

@BernatObrador BernatObrador changed the title [IMP] fieldservice: Added filter Due This Week [17.0][IMP] fieldservice: Added filter Due This Week Mar 13, 2025
peluko00
peluko00 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat and code review

mpascuall
mpascuall approved these changes Mar 13, 2025
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ppyczko
ppyczko approved these changes Mar 13, 2025
View reviewed changes
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Runboat.

Just a small note: the PR description states "from Monday to Saturday," but it should say "from Monday to Sunday."

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BernatObrador
Copy link
Author

@max3903 sorry for pinging you directly, is this ready to merge? Thanks!

@BernatObrador
Copy link
Author

@brian10048 Could you review please? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluko00 peluko00 peluko00 approved these changes

@mpascuall mpascuall mpascuall approved these changes

@ppyczko ppyczko ppyczko approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BernatObrador @OCA-git-bot @peluko00 @mpascuall @ppyczko