[15.0][FIX] fieldservice_route: Ensure FSMRouteDay selection values are properly translated #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @max3903, |
ppyczko
force-pushed
the
15.0-fix-fieldservice_route-fsm-route-days-translations
branch
from
aa80032 to
640dcd4
Compare
ppyczko
changed the title
ppyczko
force-pushed
the
15.0-fix-fieldservice_route-fsm-route-days-translations
branch
3 times, most recently
from
6cf1bce to
d399a3e
Compare
ppyczko
force-pushed
the
15.0-fix-fieldservice_route-fsm-route-days-translations
branch
from
d399a3e to
e0358cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the translation of day names in FSMRouteDay. In some scenarios, these records were always displayed in raw English values (e.g., "Thursday") even though another language and the corresponding translations were set. Now, they properly show translations based on the user’s language if translations are present.
Before:
After:
cc https://github.com/APSL 7063
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @BernatObrador please review