Skip to content

[18.0][FIX] hr_employee_relative: add compute value for fields impacted by the compute method #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

jeromeguerriat-msf
Copy link

the method "_compute_age" assign values to the fields "age_month" and "age_day", but those fields are not marked as computed.
Therefore, when you have no write rights on the record, displaying "age_year" will end up in an access error

Copy link

@AlvaroRM11 AlvaroRM11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvalyi rvalyi changed the title [FIX] add compute value for fields impacted by the compute method [18.0][FIX] hr_employee_relative: add compute value for fields impacted by the compute method Apr 11, 2025
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Apr 21, 2025

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1458-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 650be72 into OCA:18.0 Apr 21, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 282d246. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants