[16.0][IMP] l10n_es_sigaus_sale: call sigaus from sale line creation #4108
Conversation
Tisho99
force-pushed
the
16.0-imp-l10n_es_sigaus_sale
branch
from
bb1274d to
6146074
Compare
|
@Tisho99 revisa los tests antes de los pings please. |
Tisho99
force-pushed
the
16.0-imp-l10n_es_sigaus_sale
branch
3 times, most recently
from
0417bf8 to
03f4529
Compare
Tisho99
force-pushed
the
16.0-imp-l10n_es_sigaus_sale
branch
2 times, most recently
from
78929e7 to
4e6a9d4
Compare
Tisho99
force-pushed
the
16.0-imp-l10n_es_sigaus_sale
branch
from
4e6a9d4 to
85c5455
Compare
| lines = super().create(vals_list) | ||
| if not self.env.context.get("avoid_line_recursion"): | ||
| sales = self.env["sale.order"] | ||
| for line in lines.filtered(lambda li: li.product_id.sigaus_has_amount): |
There was a problem hiding this comment.
sales = lines.filtered(lambda li: li.product_id.sigaus_has_amount).mapped('order_id')
| sales += line.order_id | ||
| for sale in sales: | ||
| sale.automatic_sigaus_exception() | ||
| sale.apply_sigaus() |
There was a problem hiding this comment.
apply_sigaus is multi.
| for line in lines.filtered(lambda li: li.product_id.sigaus_has_amount): | ||
| sales += line.order_id | ||
| for sale in sales: | ||
| sale.automatic_sigaus_exception() |
There was a problem hiding this comment.
This function could be implemented in multiple ways, not just api.one. Can you review it?
The call can be made much better if the change is made.
There was a problem hiding this comment.
I can, i'll do the improvement tomorrow
There was a problem hiding this comment.
you will have to check which other sites are affected.
Tisho99
force-pushed
the
16.0-imp-l10n_es_sigaus_sale
branch
from
85c5455 to
fc302d1
Compare
|
This PR has the |
|
@HaraldPanten could you do a review? |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 207d857. Thanks a lot for contributing to OCA. ❤️ |
There are situations when lines are created directly from the sale order line create method, and the sigaux is not updated because the create or write methods of the sale order are not called.
This PR covers those cases
Related with OCA/sale-workflow#3658
I-7204