Skip to content

[17.0][MIG] pos_margin #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 17, 2025
Merged

[17.0][MIG] pos_margin #1309

merged 26 commits into from
Apr 17, 2025

Conversation

antoniodavid
Copy link

No description provided.

@antoniodavid antoniodavid changed the title 17.0 mig pos margin [WIP][17.0][MIG] pos_margin Feb 14, 2025
@antoniodavid antoniodavid mentioned this pull request Feb 14, 2025
Open
31 tasks
@antoniodavid antoniodavid changed the title [WIP][17.0][MIG] pos_margin [17.0][MIG] pos_margin Feb 18, 2025
@Abimael1321
Copy link

Functionally reviewed. LGTM!

@antoniodavid
Copy link
Author

@Christian-RB @rrebollo reviews please

rrebollo
rrebollo approved these changes Feb 24, 2025
View reviewed changes
Copy link

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

legalsylvain commented Feb 24, 2025 •
edited
Loading

hi.
could you squash all the V17 migration commits together ?

thanks !

image

@antoniodavid antoniodavid force-pushed the 17.0-mig-pos_margin branch 2 times, most recently from 40d104d to 6545744 Compare February 24, 2025 23:05
@antoniodavid
Copy link
Author

hi. could you squash all the V17 migration commits together ?

thanks !

image

Done

legalsylvain
legalsylvain approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff review. LGTm.

@antoniodavid
Copy link
Author

ping @legalsylvain

@Christian-RB
Copy link

You need to squash the commits again @antoniodavid

francesco-ooops and others added 16 commits April 15, 2025 11:43
@francesco-ooops @antoniodavid
Translated using Weblate (Italian)
338807c 
Currently translated at 37.5% (3 of 8 strings)

Translation: pos-14.0/pos-14.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_margin/it/
@cvinh @antoniodavid
[FIX] Hide margin in Front End if config is false
b942046
@OCA-git-bot @antoniodavid
pos_margin 14.0.1.0.2
ab97952
@francesco-ooops @antoniodavid
Translated using Weblate (Italian)
7d05c25 
Currently translated at 37.5% (3 of 8 strings)

Translation: pos-14.0/pos-14.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_margin/it/
@suker @antoniodavid
[IMP] : pre-commit stuff
8a48500
@suker @antoniodavid
[MIG] pos_margin: Migration to 16.0
8de9e96
@antoniodavid
[UPD] Update pos_margin.pot
826f2a1
@OCA-git-bot @antoniodavid
[UPD] README.rst
ebc71ee
@OCA-git-bot @antoniodavid
pos_margin 16.0.1.0.1
2e86908
@mymage @antoniodavid
Added translation using Weblate (Italian)
33c0772
@mymage @antoniodavid
Translated using Weblate (Italian)
9fcd7be 
Currently translated at 100.0% (8 of 8 strings)

Translation: pos-16.0/pos-16.0-pos_margin
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_margin/it/
@OCA-git-bot @antoniodavid
[UPD] README.rst
ed4bf49
@legalsylvain @antoniodavid
[FIX] eslint error 'no-shadow' in all modules
3bba7ed
@OCA-git-bot @antoniodavid
[BOT] post-merge updates
2db50c1
@antoniodavid
[IMP] pos_margin: pre-commit execution
0ac4fe7
@antoniodavid
[MIG] pos_margin: Migration to 17.0
28e5ceb
@antoniodavid
Copy link
Author

You need to squash the commits again @antoniodavid

Thanks for review

@antoniodavid
Copy link
Author

@rousseldenis do your magic

@rousseldenis
Copy link
Contributor

@rousseldenis do your magic

Sorry, no power here 😄

@antoniodavid
Copy link
Author

ping @legalsylvain

@legalsylvain
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1309-by-legalsylvain-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4290b19 into OCA:17.0 Apr 17, 2025
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7f0b1cc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain approved these changes

@rrebollo rrebollo rrebollo approved these changes

@Christian-RB Christian-RB Christian-RB approved these changes

@Abimael1321 Abimael1321 Abimael1321 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.