[16.0][FIX]pos_access_right: change deleteOrder to _onDeleteOrder #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-RB
approved these changes
Apr 21, 2025
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 155ad2d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the
deleteOrdermethod in theTicketScreencomponent is no longer used in Odoo 16.0 — it has been renamed to_onDeleteOrder. https://github.com/odoo/odoo/blob/bfeab2559f9a0df8790322bac0fe3b2a09d3f9c9/addons/point_of_sale/static/src/js/Screens/TicketScreen/TicketScreen.js#L108After checking on Runboat, I also found that the permission intended to disable order deletion is currently not functioning as expected.
To improve maintainability and extensibility, I’ve restructured the code within the
_onDeleteOrdermethod, making it easier to inherit and override in custom modules.