[16.0][FIX] sale_order_product_recommendation: recommendations on sales with section or notes #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yajo, @rafaelbn, @sergio-teruel, |
Tisho99
force-pushed
the
16.0-fix-sale_order_product_recommendation
branch
from
6ac417c to
3fe70c0
Compare
rousseldenis
reviewed
Apr 7, 2025
| @@ -160,7 +160,9 @@ def generate_recommendations(self): | |||
| existing_product_ids = set() | |||
| # Always recommend all products already present in the linked SO except delivery | |||
| # carrier products | |||
| for line in self.order_id.order_line.filtered(lambda ln: not ln._is_delivery()): | |||
| for line in self.order_id.order_line.filtered( | |||
| lambda ln: not (ln._is_delivery() or ln.display_type) | |||
There was a problem hiding this comment.
Could you add a test with a note or section ?
Jaimermaccione
approved these changes
Apr 7, 2025
Tisho99
force-pushed
the
16.0-fix-sale_order_product_recommendation
branch
from
3fe70c0 to
63880d5
Compare
| @@ -127,6 +127,21 @@ def test_recommendations_ordered_by_code(self): | |||
| ], | |||
| ) | |||
|
|
|||
| def test_recommendations_with_note(self): | |||
There was a problem hiding this comment.
What do you do in this test?
There was a problem hiding this comment.
Generate the recomendations with the wizard in a sale order with notes. It is what gives an error without the fix
…h section or notes
Tisho99
force-pushed
the
16.0-fix-sale_order_product_recommendation
branch
from
63880d5 to
7a0baff
Compare
manuelregidor
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to use the recommendation wizard in a sales order with section or notes, an error will be displayed when trying to get the recommendations.
The reason is because it tries to read the section's product, and it does not exist.
This PR fixes it
I-7204