[14.0][IMP] endpoint: support usage of querystring parameters #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @simahawk, |
dreispt
changed the title
|
Review is appreciated but please don't merge yet, there might be a few changes. |
dreispt
force-pushed
the
14-dr-endpoint-params
branch
from
d1bff46 to
3532d63
Compare
|
Ready for review. |
simahawk
requested changes
Jan 31, 2025
| @@ -76,8 +76,10 @@ def _default_code_snippet_docs(self): | |||
| * Response | |||
| * werkzeug | |||
| * exceptions | |||
| * params | |||
There was a problem hiding this comment.
Suggested change
| * params | |
| * querystring_params |
| @@ -134,10 +136,11 @@ def _code_snippet_log_func(self, message, level="info"): | |||
| ), | |||
| ) | |||
|
|
|||
| def _handle_exec__code(self, request): | |||
| def _handle_exec__code(self, request, params=None): | |||
There was a problem hiding this comment.
Suggested change
| def _handle_exec__code(self, request, params=None): | |
| def _handle_exec__code(self, request, querystring_params=None): |
| @@ -17,7 +17,7 @@ def _handle_endpoint(self, env, model, endpoint_route, **params): | |||
| if not endpoint: | |||
| raise NotFound() | |||
| endpoint._validate_request(request) | |||
| result = endpoint._handle_request(request) | |||
| result = endpoint._handle_request(request, params=params) | |||
There was a problem hiding this comment.
Suggested change
| result = endpoint._handle_request(request, params=params) | |
| result = endpoint._handle_request(request, querystring_params=params) |
| if not self._code_snippet_valued(): | ||
| return {} | ||
| eval_ctx = self._get_code_snippet_eval_context(request) | ||
| eval_ctx["params"] = params or {} |
There was a problem hiding this comment.
Suggested change
| eval_ctx["params"] = params or {} | |
| eval_ctx["querystring_params"] = querystring_params or {} |
| @@ -184,14 +187,18 @@ def _get_handler(self): | |||
| _("Missing handler for exec mode %s") % self.exec_mode | |||
| ) | |||
|
|
|||
| def _handle_request(self, request): | |||
| def _handle_request(self, request, params=None): | |||
There was a problem hiding this comment.
Suggested change
| def _handle_request(self, request, params=None): | |
| def _handle_request(self, request, querystring_params=None): |
| # Switch user for the whole process | ||
| self_with_user = self | ||
| if self.exec_as_user_id: | ||
| self_with_user = self.with_user(user=self.exec_as_user_id) | ||
| handler = self_with_user._get_handler() | ||
| try: | ||
| res = handler(request) | ||
| # In case the handler does not support params |
There was a problem hiding this comment.
I doubt we have any other handler ATM but just in case... ok, let's keep this but I would add a separated commit for backward compat that we can easily drop on migration.
Something like:
[imp] endpoint: support querystring params
[imp] endpoint: backward compat for querystring params
Old handlers might not accept this new kw args
Trash this commit in future versions. Eg: v18.
Comment on lines
+198
to
+199
| if params: | ||
| res = handler(request, params=params) |
There was a problem hiding this comment.
Suggested change
| if params: | |
| res = handler(request, params=params) | |
| if querystring_params: | |
| res = handler(request, querystring_params=querystring_params) |
dreispt
force-pushed
the
14-dr-endpoint-params
branch
from
3532d63 to
f002179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.