Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cloning the ODataDeserializerContext #1466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khodaie
Copy link

@khodaie khodaie commented Jun 7, 2018

Description

When cloning of the ODataDeserializerContext in the ODataResourceDeserializer, the Request and RequestContext properties should be set.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

When cloning of the ODataDeserializerContext in the ODataResourceDeserializer, the Request and RequestContext properties should be set.
@xuzhg
Copy link
Member

xuzhg commented Jun 27, 2018

@khodaie Would you please share us more about your usage? Or Would you please file an issue to illustrate why do you want to set these two properties? By the way, your change can't work for both Classic and Core version. Would you please update your PR?

@khodaie
Copy link
Author

khodaie commented Jul 3, 2018

@xuzhg I have a customized ODataResourceDeserializer and I need to access the current request properties in the overridden ReadEntry method. I used the readContext.Request.Properties, but the NullReferenceException was thrown. (readContext.Request is null)

@pdbruno
Copy link
Contributor

pdbruno commented Mar 18, 2021

Hello! I found the exact same issue. It is also happening in the method ReadNestedResourceSetInline(). Could you add this fix in the commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants