Update: add --force, --enable-sriov to opae.io #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --force and --enable-sriov options to the subparser for opae.io init. The --force option enables controlling the force parameter to vfio_init() that was previously hard-coded to False. The --enable-sriov option, when given, causes opae.io init to write 'Y' to /sys/module/vfio_pci/parameters/enable_sriov. The default value for both options is False. Signed-off-by: Tim Whisonant <[email protected]>
Pull Request Test Coverage Report for Build 6792808737
💛 - Coveralls |
fpgamatt
reviewed
Nov 8, 2023
binaries/opae.io/opae/io/utils.py
Outdated
| def vfio_init(pci_addr, new_owner='', force=False): | ||
| def enable_sriov(enable): | ||
| sriov = '/sys/module/vfio_pci/parameters/enable_sriov' | ||
| if os.path.exists(sriov): |
Contributor
There was a problem hiding this comment.
The Linux kernel folks would suggest trying to minimize indentation by something like the following:
if not os.path.exists(sriov):
LOG.error("Cannot enable sriov because {sriov} does not exist")
return FALSE
try:...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add --force and --enable-sriov options to the subparser for opae.io init. The --force option enables controlling the force parameter to vfio_init() that was previously hard-coded to False.
The --enable-sriov option, when given, causes opae.io init to write 'Y' to /sys/module/vfio_pci/parameters/enable_sriov.
The default value for both options is False.
Collateral (docs, reports, design examples, case IDs):
Tests added:
Tests run:
$ cat /sys/module/vfio_pci/parameters/enable_sriov
N
$ sudo opae.io init -e -d 0000:ca:00.0 tswhison:tswhison
$ cat /sys/module/vfio_pci/parameters/enable_sriov
Y