fix openssl version check #3147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax the regular expression used to check the OpenSSL version to support the versions like the one produced by SUSE 15. Signed-off-by: Matthew Gerlach <[email protected]>
pcolberg
approved these changes
Jan 16, 2025
Contributor
pcolberg
left a comment
pcolberg
left a comment
There was a problem hiding this comment.
Thanks @fpgamatt.
For reference, could you provide the verbatim version string that failed to match?
Do you know the historical reason for not using a Python library, e.g., cryptography?
Contributor
|
Actions failures are resolved in #3148. |
Contributor
Author
|
"OpenSSL 1.1.1l-fips 24 Aug 2021 SUSE release 150400.7.75.1" is the version string that broke the existing regular expression. I don't know the history of the use of libcrypt versus a python module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the regular expression used to check the OpenSSL version to support the versions like the one produced by SUSE 15.
PR Title should start with one of the following tags: [Fix]/[Feature]/[Style]/[Update]
[Fix]- Bug Fix
[Feature]- for new feature
[Style]- Grammar or branding fix
[Update]-For an update to an existing feature
------------- Keep everything below this line -------------------------
Description
Describe the issue, update, change or fix and why
Collateral (docs, reports, design examples, case IDs):
Tests added:
Tests run: