feat: add --listen-during-wake-sound argument by wangwillian0 · Pull Request #273 · OHF-Voice/linux-voice-assistant

wangwillian0 · 2026-03-28T02:35:39Z

Hi all, wouldn't it make sense to make the microphone startup configurable (e.g. LVA_LISTEN_DURING_WAKE_SOUND) to either starting right after the wake word is detected or after the wake sound is played?

The use case is to be able to trigger a command with a single sentence without pauses, as discussed in topics like:

https://community.home-assistant.io/t/wth-must-i-pause-after-saying-the-wake-word/804292
https://www.reddit.com/r/homeassistant/comments/1d3nhys/does_anyone_have_a_nopause_needed_fix_for_wake/

The wake sound feedback can also be handled by software with echo cancelation modules on the pipewire/pulseaudio side (https://docs.pipewire.org/page_module_echo_cancel.html).

I also added a small fix for the doc of other command line argument

machineonamission · 2026-03-28T02:42:04Z

oh perfect i needed this

florian-asche · 2026-03-28T19:07:28Z

Cool feature <3

Removed TIMER_MAX_RING_SECONDS from configuration options.

omaramin-2000 · 2026-03-28T21:10:28Z

Seems good, but make sure that this won't cause confusion with STT.

wangwillian0 · 2026-03-28T22:09:52Z

Seems good, but make sure that this won't cause confusion with STT.

It will depend heavily on your setup (e.g. distance between mic and speaker, AEC enabled, etc), your wake sound (e.g. beep vs "yes, sir"), and your STT model (e.g. if it will transcribe "beep" literally).

Anyway, the feature is disabled by default.

machineonamission · 2026-03-29T02:14:42Z

Id add in the docs that this feature does heavily depend on effective AEC, and mention the pipewire software aec section as well as hardware stuff

wangwillian0 · 2026-03-29T04:57:25Z

Id add in the docs that this feature does heavily depend on effective AEC, and mention the pipewire software aec section as well as hardware stuff

Can you check the latest version of the PR? I tried to add a link to the existing AEC doc file.

I'm not sure if I agree that it depends heavily on the AEC, though, since the default wake sound is just a beep, which the STT should in the worst case treat it like an onomatopoeia, adding literally a "beep" to the phrase.

machineonamission · 2026-03-29T04:58:47Z

Less about onamonapea and more that bad aec + bad stt would struggle to pick up on voice over the audio

But also sorry I'm very drunk right now 😅

Add listen_during_wake_sound field to ServerState (default true).

Add listen_during_wake_sound option to AppConfig (default true, preserving fork's existing behavior). When false, LVA waits for the wakeup sound to finish before streaming audio to HA, useful for setups without effective AEC.

Split _start_conversation into two paths based on listen_during_wake_sound. When true (default), streams audio immediately with fire-and-forget wakeup sound (existing behavior). When false, plays wakeup sound with done_callback to _on_wakeup_sound_finished, which starts streaming after the sound completes. Port upstream PR OHF-Voice#271: Promote voice event logging from DEBUG to INFO in handle_voice_event for pipeline visibility without --debug.

Pass config.app.listen_during_wake_sound to ServerState constructor.

Document listen_during_wake_sound option with AEC guidance.

Add listen_during_wake_sound field to ServerState (default true).

florian-asche · 2026-04-22T17:37:05Z

Hm, we are missing the changes in the .env.example file. If we could add that shortly this can be added in the planned release.

wangwillian0 · 2026-04-23T04:56:01Z

@florian-asche Done.

florian-asche · 2026-04-23T23:21:40Z

testing this now...

Remove unused TIMER_MAX_RING_SECONDS argument handling

feat: add --listen-during-wake-sound argument

9b4cebb

wangwillian0 had a problem deploying to pr-build March 28, 2026 02:35 — with GitHub Actions Failure

Update docstring for audio streaming callback

92ca777

wangwillian0 had a problem deploying to pr-build March 28, 2026 02:39 — with GitHub Actions Failure

florian-asche requested changes Mar 28, 2026

View reviewed changes

Comment thread docs/install_application.md Outdated

Comment thread README.md Outdated

florian-asche added the enhancement New feature or request label Mar 28, 2026

florian-asche self-assigned this Mar 28, 2026

Remove TIMER_MAX_RING_SECONDS from install documentation

040b99e

Removed TIMER_MAX_RING_SECONDS from configuration options.

wangwillian0 had a problem deploying to pr-build March 28, 2026 20:02 — with GitHub Actions Failure

Remove default value for timer-max-ring-seconds

fe3f9d3

wangwillian0 had a problem deploying to pr-build March 28, 2026 20:04 — with GitHub Actions Failure

improve listen_during_wake_sound doc

43b17ec

wangwillian0 had a problem deploying to pr-build March 28, 2026 20:30 — with GitHub Actions Failure

Merge branch 'main' into feat/listen-during-wake-sound

590bcf7

florian-asche temporarily deployed to pr-build March 30, 2026 00:23 — with GitHub Actions Inactive

Merge branch 'main' into feat/listen-during-wake-sound

2fd722d

florian-asche temporarily deployed to pr-build March 30, 2026 19:04 — with GitHub Actions Inactive

Merge branch 'main' into feat/listen-during-wake-sound

2574f68

wangwillian0 temporarily deployed to pr-build March 31, 2026 05:47 — with GitHub Actions Inactive

wangwillian0 requested a review from florian-asche April 6, 2026 23:06

Merge branch 'main' into feat/listen-during-wake-sound

464170a

omaramin-2000 temporarily deployed to pr-build April 9, 2026 23:37 — with GitHub Actions Inactive

imonlinux added a commit to imonlinux/linux-voice-assistant that referenced this pull request Apr 13, 2026

Port upstream PR OHF-Voice#273

bc55fc5

Add listen_during_wake_sound field to ServerState (default true).

imonlinux added a commit to imonlinux/linux-voice-assistant that referenced this pull request Apr 13, 2026

Port upstream PR OHF-Voice#273

58ba8b5

Pass config.app.listen_during_wake_sound to ServerState constructor.

imonlinux added a commit to imonlinux/linux-voice-assistant that referenced this pull request Apr 13, 2026

Port upstream PR OHF-Voice#273:

d3cb43a

Document listen_during_wake_sound option with AEC guidance.

imonlinux added a commit to imonlinux/linux-voice-assistant that referenced this pull request Apr 13, 2026

Port upstream PR OHF-Voice#273

161b2f8

Add listen_during_wake_sound field to ServerState (default true).

imonlinux added a commit to imonlinux/linux-voice-assistant that referenced this pull request Apr 13, 2026

Port upstream PR OHF-Voice#273

7050113

Add listen_during_wake_sound field to ServerState (default true).

Merge branch 'main' into feat/listen-during-wake-sound

259968c

omaramin-2000 temporarily deployed to pr-build April 20, 2026 13:43 — with GitHub Actions Inactive

Merge branch 'main' into feat/listen-during-wake-sound

8dbc3fa

omaramin-2000 temporarily deployed to pr-build April 21, 2026 00:19 — with GitHub Actions Inactive

Merge branch 'main' into feat/listen-during-wake-sound

5fbf03e

florian-asche temporarily deployed to pr-build April 22, 2026 17:36 — with GitHub Actions Inactive

chore: add LISTEN_DURING_WAKE_SOUND to .env.example

1b434d7

wangwillian0 temporarily deployed to pr-build April 23, 2026 04:55 — with GitHub Actions Inactive

Merge branch 'main' into feat/listen-during-wake-sound

caff3a4

florian-asche temporarily deployed to pr-build April 23, 2026 23:20 — with GitHub Actions Inactive

Remove TIMER_MAX_RING_SECONDS from entrypoint script

e015993

Remove unused TIMER_MAX_RING_SECONDS argument handling

florian-asche temporarily deployed to pr-build April 25, 2026 01:09 — with GitHub Actions Inactive

Fix formatting in satellite.py

849d87a

florian-asche temporarily deployed to pr-build April 25, 2026 01:15 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add --listen-during-wake-sound argument#273

feat: add --listen-during-wake-sound argument#273
wangwillian0 wants to merge 16 commits into
OHF-Voice:mainfrom
wangwillian0:feat/listen-during-wake-sound

wangwillian0 commented Mar 28, 2026

Uh oh!

machineonamission commented Mar 28, 2026

Uh oh!

florian-asche commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

omaramin-2000 commented Mar 28, 2026

Uh oh!

wangwillian0 commented Mar 28, 2026 •

edited

Loading

Uh oh!

machineonamission commented Mar 29, 2026

Uh oh!

wangwillian0 commented Mar 29, 2026

Uh oh!

machineonamission commented Mar 29, 2026

Uh oh!

florian-asche commented Apr 22, 2026

Uh oh!

wangwillian0 commented Apr 23, 2026

Uh oh!

florian-asche commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wangwillian0 commented Mar 28, 2026

Uh oh!

machineonamission commented Mar 28, 2026

Uh oh!

florian-asche commented Mar 28, 2026

Uh oh!

Uh oh!

Uh oh!

omaramin-2000 commented Mar 28, 2026

Uh oh!

wangwillian0 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

machineonamission commented Mar 29, 2026

Uh oh!

wangwillian0 commented Mar 29, 2026

Uh oh!

machineonamission commented Mar 29, 2026

Uh oh!

florian-asche commented Apr 22, 2026

Uh oh!

wangwillian0 commented Apr 23, 2026

Uh oh!

florian-asche commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wangwillian0 commented Mar 28, 2026 •

edited

Loading