Enable setuptools-scm#319
Open
mweinelt wants to merge 3 commits into
Open
Conversation
mweinelt
force-pushed
the
setuptool-scm-enable
branch
from
b383615 to
56c3548
Compare
mweinelt
force-pushed
the
setuptool-scm-enable
branch
from
56c3548 to
5d6da09
Compare
mweinelt
force-pushed
the
setuptool-scm-enable
branch
from
5d6da09 to
157bc3c
Compare
mweinelt
force-pushed
the
setuptool-scm-enable
branch
from
157bc3c to
a44f73e
Compare
This fixes the package version, since setuptools-scm needs to be enabled through the existence of its config section. The Docker container is now passed a VERSION attribute at build time that for CI jobs is derived from the Git tree. This is necessary because the Git tree is not copied into the Docker container.
With --tag we get a version relative to the last tag, while with --always we sometimes just get a short hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the package version, since setuptools-scm needs to be enabled through the existence of its config section.
From
To
This requires further changes to the container builds, since they don't have a
.gittree to pull the version info from. Instead, we usegit describeat build time to come up with a version.With that change applied the package version can be looked up from package metadata and
version.txtis not required any longer.