-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust rewrite #62
Draft
OMGtechy
wants to merge
51
commits into
master
Choose a base branch
from
refactor/rust-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rust rewrite #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully better support M1 macs.
This saves having to modify this line every time a new arg is added.
We have source control and can use that to refer back to it when required.
0c1a8f5
to
88f2c0a
Compare
Coverage is removed for now.
88f2c0a
to
f9f32a4
Compare
The force pushes are attempts at triggering GitHub actions. Doesn't matter too much as I am currently the only person working on this, as far as I know. |
It feels like there's probably a better way to do this... Ideally I'd take the pid of the child process into account too.
I'll probably end up using this for "top functions" - just wanted to get this commited as it's a useful working reference point.
Committing it now gives a useful reference point, as I now plan on tidying it up.
6a677c1
to
508a8bc
Compare
It's not displayed in the TUI yet.
Not too useful to a user, but a stepping stone towards getting things like function names in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.