Open
Conversation
Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
… for more robust testing
…tly used in webdriverv8 Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
…on and interestital spec
…plemenetary data tests are executing before page is rendered Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
Signed-off-by: Yuyutsu Rai <Yuyutsu.Rai@ons.gov.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR upgrades all WDIO packages to
v9.21.0and updates our functional tests to comply with the new upgrades.Changes made
getHTML()no longer takes a boolean flag. It now accepts an options object. The default options:({ includeSelectorTag: true, prettify: true })were causing differences in the returned HTML, which led to assertion failures (formatting changes and missing alt attributes on logo tags). We have to explicitly set these values to false.newWindow()now needs to explicitly have a URL value. In v8,newWindow()implicitly openedabout:blankwhen no URL was provided. In v9 this implicit default was removed, so we now explicitly pass 'about:blank' when opening a new window.SDS Tests in GA are failing when in the main test, but work when separated into their own job with "MAX_INSTANCE=1". Also the very first SDS launch always hits the “Sorry, there is a problem with this service” page. So a new helper function -
openQuestionnaireWithRetry(). I think we need an investigation on why SDS is failing like this in GA only.Chrome options also updated in an attempt to make tests more consistent.
Babel dependencies have also been upgraded to latest versions
How to review
Links
Checklist