Open
Conversation
VirajP1002
approved these changes
Jun 7, 2024
Contributor
VirajP1002
left a comment
VirajP1002
left a comment
There was a problem hiding this comment.
Works really nicely! Tests pass and changes look good. I also tested the changes in Runner and validation works as intended!
petechd
reviewed
Jun 10, 2024
petechd
reviewed
Jun 10, 2024
petechd
reviewed
Jun 10, 2024
petechd
reviewed
Jun 11, 2024
petechd
reviewed
Jun 12, 2024
petechd
reviewed
Jun 12, 2024
Co-authored-by: petechd <[email protected]>
petechd
approved these changes
Jun 13, 2024
petechd
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Adds validation to identify any invalid HTML in our translatable strings e.g. anything that is not using
<strong>or<a>.How to review
Check that the validation is working as expected
Checklist