Skip to content

feat(a11y): add ARIA labels to navigation and polite announcements to… #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajshekharbind merged 2 commits into from
Oct 16, 2025
Merged

feat(a11y): add ARIA labels to navigation and polite announcements to… #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7dc18
feat(a11y): add ARIA labels to navigation and polite announcements to…
ayushhh101 Oct 14, 2025
fc3737a
Merge branch 'main' into feat/a11y-nav-and-notifications
ayushhh101 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ const Navigation = () => {
exit={{ x: -320 }}
transition={{ type: 'spring', damping: 30, stiffness: 300 }}
className="fixed left-0 top-0 h-full w-64 bg-white shadow-xl z-40 lg:z-auto"
role="navigation"
aria-label="Primary"
>
<div className="p-6 border-b border-gray-200">
<div className="flex items-center space-x-3">
Expand Down
8 changes: 4 additions & 4 deletions src/components/NotificationList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { motion, AnimatePresence } from 'framer-motion';
import { AnimatePresence, motion as Motion } from 'framer-motion';
import { useNotification } from '../context/NotificationContext';
import { formatTime, formatDate } from '../utils/format';

Expand Down Expand Up @@ -41,10 +41,10 @@ const NotificationList = () => {
)}
</div>

<div className="space-y-3 max-h-96 overflow-y-auto">
<div className="space-y-3 max-h-96 overflow-y-auto" aria-live="polite">
<AnimatePresence>
{notifications.map((notification, index) => (
<motion.div
<Motion.div
key={notification.id}
initial={{ opacity: 0, x: -20 }}
animate={{ opacity: 1, x: 0 }}
Expand Down Expand Up @@ -74,7 +74,7 @@ const NotificationList = () => {
✕
</button>
</div>
</motion.div>
</Motion.div>
))}
</AnimatePresence>

Expand Down
Loading