Skip to content

Document the parameters that define a supercapacitor #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

Rombur
Copy link
Collaborator

@Rombur Rombur commented Aug 29, 2017

This is a first step in fixing #252 This is only the parameters used by supercapacitor. This helps building the input deck and make it easier to grep the code for parameters.

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #259 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          72       72           
  Lines        5117     5117           
=======================================
  Hits         4861     4861           
  Misses        256      256

Copy link
Collaborator

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a cheat_sheet.md file rather than putting this directly in the doc that is addressed to less advanced users.

@Rombur
Copy link
Collaborator Author

Rombur commented Sep 12, 2017

OK done.

@Rombur Rombur merged commit 3ce01f0 into ORNL-CEES:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants