Skip to content

Set up pre-commit hook for clang-format #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 5, 2025
Merged

Set up pre-commit hook for clang-format #68

merged 8 commits into from
Mar 5, 2025

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented Mar 4, 2025 •
edited
Loading

Closes #26
Closes #33

@pelesh pelesh marked this pull request as ready for review March 4, 2025 05:42
@pelesh pelesh self-assigned this Mar 4, 2025
@pelesh pelesh added the testing label Mar 4, 2025
This was referenced Mar 4, 2025
Closed
Closed
Closed
@pelesh pelesh requested a review from reid-g March 4, 2025 16:40
nkoukpaizan
nkoukpaizan approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@nkoukpaizan nkoukpaizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Otherwise, looks good to me.

@pelesh @nkoukpaizan
[skip ci] Fix typo in CONTRIBUTING.md
06f6f8e 
Co-authored-by: Nicholson Koukpaizan <[email protected]>
@pelesh pelesh merged commit 4421f70 into develop Mar 5, 2025
@pelesh pelesh deleted the style-format-dev branch March 14, 2025 03:37
pelesh added a commit that referenced this pull request Apr 14, 2025
@pelesh @alexander-novo @nkoukpaizan
Set up pre-commit hook for clang-format (#68)
f34ee82 
* Update clang-format rules.

* Add pre-commit hooks.

* Update CONTRIBUTING.md.

* Reformatted code per style guidelines.

* Fix bug in Branch and Load models.

* Update contributing guidelines.


---------

Co-authored-by: pelesh <[email protected]>
Co-authored-by: alexander-novo <[email protected]>
Co-authored-by: Nicholson Koukpaizan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-novo alexander-novo alexander-novo approved these changes

@nkoukpaizan nkoukpaizan nkoukpaizan approved these changes

@reid-g reid-g Awaiting requested review from reid-g

Assignees

@pelesh pelesh

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pre-commit actions Create a .clang-format file
3 participants
@pelesh @alexander-novo @nkoukpaizan