Skip to content

Added back removed test for N=8 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

shakedregev
Copy link
Collaborator

@shakedregev shakedregev commented Apr 25, 2025

Description

The $N=8$ test was removed from this example. I believe this is a bug. I also added an enhancement of fitting variable names with styling guidelines.

No relevant issues

Proposed changes

I deleted the backslash so the test actually runs. Works flawlessly.
I changed variable names to have underscores between words.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

N/A.

@shakedregev shakedregev requested a review from pelesh April 25, 2025 20:38
@pelesh pelesh requested a review from reid-g April 25, 2025 22:23
@pelesh pelesh added enhancement New feature or request testing labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants