Skip to content

Refactor and stand alone examples for KLU class #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 1, 2025

Conversation

shakedregev
Copy link
Collaborator

@shakedregev shakedregev commented Apr 7, 2025

This PR is an enhancement solving Issue 250

kluRefactor.exe and kluStandAlone.exe are now decluttered using ExampleHelper and CliOptions. I kept the two original files, but they are not needed.

Tests pass on CPU.

@shakedregev shakedregev requested review from pelesh and Copilot April 7, 2025 19:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

Files not reviewed (1)
  • examples/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)

examples/kluStandAlone.cpp:71

  • [nitpick] Log message refers to 'sysRefactor' instead of 'kluStandAlone'; update the message for consistency with the executable name.
std::cout << "sysRefactor with " << helper.getHardwareBackend() << " backend\n";

@pelesh pelesh requested a review from maksud April 7, 2025 21:17
pelesh
pelesh previously requested changes Apr 7, 2025
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KLU examples are not really decluttered and they do not use ExampleHelper class. Also, CliOptions class should be used to process command line input.

@pelesh pelesh marked this pull request as draft April 7, 2025 21:34
@shakedregev shakedregev requested review from Copilot and pelesh April 8, 2025 13:53
@shakedregev shakedregev marked this pull request as ready for review April 8, 2025 13:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

Files not reviewed (1)
  • examples/CMakeLists.txt: Language not supported

pelesh
pelesh previously requested changes Apr 18, 2025
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress. A few changes requested before we can merge this.

@shakedregev shakedregev requested a review from pelesh April 21, 2025 15:54
@shakedregev
Copy link
Collaborator Author

Nice progress. A few changes requested before we can merge this.

@pelesh - made the necessary changes. This is ready

@maksud maksud force-pushed the shaked/refactor_standalone_klu branch from 83c31b3 to 044636c Compare April 21, 2025 16:16
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@pelesh pelesh merged commit 2443aef into refactor-examples-dev May 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants