-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor and stand alone examples for KLU class #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
Files not reviewed (1)
- examples/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
examples/kluStandAlone.cpp:71
- [nitpick] Log message refers to 'sysRefactor' instead of 'kluStandAlone'; update the message for consistency with the executable name.
std::cout << "sysRefactor with " << helper.getHardwareBackend() << " backend\n";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KLU examples are not really decluttered and they do not use ExampleHelper
class. Also, CliOptions
class should be used to process command line input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
Files not reviewed (1)
- examples/CMakeLists.txt: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice progress. A few changes requested before we can merge this.
@pelesh - made the necessary changes. This is ready |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
83c31b3
to
044636c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
This PR is an enhancement solving Issue 250
kluRefactor.exe
andkluStandAlone.exe
are now decluttered usingExampleHelper
andCliOptions
. I kept the two original files, but they are not needed.Tests pass on CPU.