Fixed LinSolverDirectKLU incorrectly assuming CSC format #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue 251.
I added a check on the sparse format of the matrix$A$ .$A^T$ . The identity $\mathrm{csc}(A) = \mathrm{csr}(A^T)$ guarantees the results are equal, up to numerical precision.
If CSC, the solver resumes normally, calling
klu_solveIf CSR, the solver calls
klu_tsolveand solves a system withNote that the tolerance for the test was smaller than numerical precision. It had to be changed to numerical precision for the test to pass.