IOT-46: Time limited access #202
Conversation
| @@ -21,6 +21,10 @@ <h3>{{ "USERS.DETAIL.HEADLINE" | translate }}</h3> | |||
| <strong>{{ "USERS.DETAIL.STATUS" | translate }}</strong | |||
| >{{ user.active | activeDeactive }} | |||
| </p> | |||
| <p *ngIf="user.expiresOn"> | |||
| <strong>{{ "API-KEY.EXPIRES-ON" | translate }}</strong> | |||
| {{ (user.expiresOn) | dateOnly }} | |||
There was a problem hiding this comment.
Can it be done so it doesnt always translate to english? If it's not easy then it might not matter
| {{ "API-KEY.EXPIRES-ON" | translate }} | ||
| </th> | ||
| <td *matCellDef="let element" mat-cell> | ||
| {{ (element.expiresOn | dateOnly) ?? '-' }} |
There was a problem hiding this comment.
Can it be done so it doesnt always translate to english? If it's not easy then it might not matter
| @@ -21,6 +21,10 @@ <h3>{{ "USERS.DETAIL.HEADLINE" | translate }}</h3> | |||
| <strong>{{ "USERS.DETAIL.STATUS" | translate }}</strong | |||
| >{{ user.active | activeDeactive }} | |||
There was a problem hiding this comment.
Don't we miss a check here? If the user is expired this should show deactivate, shouldn't it?
There was a problem hiding this comment.
Users are disabled by a service in the backend. So their expiration date is not validated expicitly in the frontend
| @@ -96,14 +97,31 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="row form-group mb-5"> | |||
There was a problem hiding this comment.
it's very close that we should make this as a component instead since it's used more than once almost copy pasted :)
There was a problem hiding this comment.
Indeed, but simple wrapper components are not that simple in Angular, and tends to add more overhead than saved. At least in my opinion
There was a problem hiding this comment.
That is true. It should be possible to create these standalone components which requires a little less boilerplate, but agreed that this might be a small enough component.
If we need some kind of datepicker input field we could consider it later.
| <div class="row form-group mb-5"> | ||
| <label class="form-label">{{ "API-KEY.EDIT.EXPIRATION-DATE" | translate }}</label> | ||
| <mat-form-field appearance="outline"> | ||
| <mat-label>{{ "API-KEY.EDIT.EXPIRATION-DATE-PLACEHOLDER" | translate }}</mat-label> |
There was a problem hiding this comment.
guess it's the same but the api-key might be misleading since this is user. Argument of why we should consider making a shared component
| <div class="row mb-5"> | ||
| <mat-slide-toggle [(ngModel)]="user.active" id="active" name="active"> | ||
| {{ "USERS.FORM.ACTIVE" | translate }}</mat-slide-toggle | ||
| {{ "USERS.FORM.ACTIVE" | translate }} |
There was a problem hiding this comment.
Should this be disabled if the user is expired?
| {{ "USERS.STATUS" | translate }} | ||
| </th> | ||
| <td mat-cell *matCellDef="let element"> | ||
| <td *matCellDef="let element" mat-cell> | ||
| <p [ngClass]="element.active | activeDeactive">{{ element.active | activeDeactive }}</p> |
There was a problem hiding this comment.
Like in the api key, should't this show deactivated if the user is expired?
| @@ -1315,12 +1316,17 @@ | |||
| "NAME-PLACEHOLDER": "Indtast nøglens navn", | |||
| "CANCEL": "Annuller", | |||
| "SAVE": "Gem nøgle", | |||
| "CREATE-API-KEY": "Opret nøgle" | |||
| "CREATE-API-KEY": "Opret nøgle", | |||
| "EXPIRATION-DATE": "Udløbsdato", | |||
There was a problem hiding this comment.
in the jira task the word "Deaktiveringsdato" is used instead. Any reason for using udløbsdato?
No description provided.