Skip to content

refactor hpc_module #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johrstrom opened this issue May 8, 2025 · 0 comments · Fixed by #4378
Closed

refactor hpc_module #4350

johrstrom opened this issue May 8, 2025 · 0 comments · Fixed by #4378
Labels
area/tech debt component/dashboard
Milestone
Backlog

Comments

@johrstrom
Copy link
Contributor

It's clear that the HpcModule class could use a little refactor so we can pull all the modules a little easier.

Seems like the all API should set the cluster attr_reader.

          It's used in the controller where we get all modules across clusters, but once I refactor that piece I can turn it into an `attr_reader` with no issue.

(Actually we might not need to read/access that at all. I was just making things difficult)

ondemand/apps/dashboard/app/controllers/module_browser_controller.rb

Lines 7 to 10 in 51b66b9

# TODO: Modify HpcModule to return all modules across all clusters
@modules = @clusters.flat_map do |cluster|
HpcModule.all(cluster.id).each { |mod| mod.cluster = cluster.id }
end

Originally posted by @ahmed-mgd in #4348 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tech debt component/dashboard
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Refactor HpcModule to return all modules across clusters OSC/ondemand
3 participants
@johrstrom @osc-bot @moffatsadeghi