Refactor HpcModule to return all modules across clusters #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is going to fail for some time until I can sort it out. |
johrstrom
reviewed
May 23, 2025
| end.flatten.uniq.reject(&:hidden?) | ||
| rescue StandardError => e | ||
| Rails.logger.warn("Did not read #{file} correctly because #{e.class}:#{e.message}") | ||
| def all(cluster = nil) |
There was a problem hiding this comment.
Can this be a keyword parameter instead of a positional one? I think it's just a little nicer because then you can call all without anything.
|
Looks like there were some unit tests for this that we need to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4350 and refactors mod browser components accordingly