Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.clump: added tests for r.clump module #4733

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
70 changes: 70 additions & 0 deletions raster/r.clump/tests/test_clump.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import pytest
from grass.script import run_command, read_command, parse_command


@pytest.fixture(scope="module")
def setup_map():
"""Set up a temporary region and generate a clumped map."""
# Set the region
run_command("g.region", n=3, s=0, e=3, w=0, res=1)

# Create the custom map
# 5 null null
# null 5 null
# null 6 6
run_command(
"r.mapcalc",
expression=(
"custom_map = "
"if(row() == 1 && col() == 1, 5, "
"if(row() == 2 && col() == 2, 5, "
"if(row() == 3 && col() >= 2, 6, null())))"
),
overwrite=True,
)
yield

# Teardown: Remove maps
run_command(
"g.remove", flags="f", type="raster", name=["custom_map", "clumped_map"]
)


def test_clump_basic(setup_map):
"""Test basic clumped map."""

run_command("r.clump", input="custom_map", output="clumped_map", overwrite=True)

output_maps = parse_command("g.list", type="raster")
assert "clumped_map" in output_maps, "Output raster map 'clumped_map' should exist"

category_output = read_command("r.category", map="clumped_map").strip().split("\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r.category has json output, you can use parse_command to get the list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because r.category already has format option, the call is more complicated:

import json
gs.parse_command("r.category", map="clumped_map", output_format="json", parse=(json.loads, {}))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be done.

actual_categories = {
int(line.split("\t")[0]): line.split("\t")[1].strip() if "\t" in line else ""
for line in category_output
}

expected_categories = {1: "", 2: "", 3: ""}
petrasovaa marked this conversation as resolved.
Show resolved Hide resolved

assert set(actual_categories.keys()) == set(expected_categories.keys())


def test_clump_diagonal(setup_map):
"""Test clumped map with diagonal connectivity."""

run_command(
"r.clump", input="custom_map", output="clumped_map", flags="d", overwrite=True
)

output_maps = parse_command("g.list", type="raster")
assert "clumped_map" in output_maps, "Output raster map 'clumped_map' should exist"

category_output = read_command("r.category", map="clumped_map").strip().split("\n")
actual_categories = {
int(line.split("\t")[0]): line.split("\t")[1].strip() if "\t" in line else ""
for line in category_output
}

expected_categories = {1: "", 2: ""}

assert set(actual_categories.keys()) == set(expected_categories.keys())

Unchanged files with check annotations Beta

- name: Set number of cores for compilation
run: |
echo "MAKEFLAGS=-j$(nproc)" >> $GITHUB_ENV

Check warning on line 149 in .github/workflows/python-code-quality.yml

GitHub Actions / Python Code Quality Checks (ubuntu-22.04)

Temporarily downgraded pytest-pylint and pytest to allow merging other PRs. The errors reported with a newer version seem legitimite and should be fixed (2023-10-18, see https://github.com/OSGeo/grass/pull/3205) (2024-01-28, see https://github.com/OSGeo/grass/issues/3380)
- uses: rui314/setup-mold@b015f7e3f2938ad3a5ed6e5111a8c6c7c1d6db6e # v1
- name: Build
run: .github/workflows/build_${{ matrix.os }}.sh $HOME/install