Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update contributing docs to refer to ruff format #5027

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

echoix
Copy link
Member

@echoix echoix commented Feb 2, 2025

With #5023 merged, adapt some docs and references to ruff and ruff format

@echoix echoix requested a review from wenzeslaus February 2, 2025 21:40
@github-actions github-actions bot added CI Continuous integration docs labels Feb 2, 2025
@echoix echoix enabled auto-merge (squash) February 4, 2025 12:01
@echoix echoix requested a review from neteler February 4, 2025 12:02
@neteler
Copy link
Member

neteler commented Feb 5, 2025

In this file are still traces of black, is that desired?

@echoix
Copy link
Member Author

echoix commented Feb 5, 2025

In this file are still traces of black, is that desired?

Yes. For PRs and branches not updated yet, it will allow to continue accepting suggestions declared as coming from black. It's an "allow list" of valid values. Since that workflow doesn't run from the context of the PR, an old PR will not use an old version of this file.

There's no real drawbacks of keeping it there for as long as we'd want. This file is also exactly the same as grass-addons, with the exception of the names of the workflows to get triggered on.

doc/development/style_guide.md Outdated Show resolved Hide resolved
doc/development/style_guide.md Outdated Show resolved Hide resolved
@echoix echoix disabled auto-merge February 5, 2025 18:18
@echoix echoix enabled auto-merge (squash) February 5, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants