Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommendation and recommendation blurb functionality #3742

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

tsu-ki
Copy link
Contributor

@tsu-ki tsu-ki commented Feb 28, 2025

Closes: #2632

Screen.Recording.2025-02-28.at.8.09.28.PM.mov

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Feb 28, 2025

@DonnieBLT sir, should I add hover functionality over the recommendations dropdown list button? So, whenever user hovers their cursor over the button, the dropdown list is displayed?

@DonnieBLT
Copy link
Collaborator

all should be expanded there should be no hover lists

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure everything is expanded on the use profile so there is no hover lists

@DonnieBLT
Copy link
Collaborator

please also fix any CodeQL errors

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Mar 1, 2025

all should be expanded there should be no hover lists

so, a card display would fit the description and would look presentable. But wouldn't that occupy a lot of space on user profile page?

@DonnieBLT
Copy link
Collaborator

You can make it look like this as a section on the bottom of the profile showing the last two recommendations with a view more link if there are more than two:
image

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Mar 1, 2025

You can make it look like this as a section on the bottom of the profile showing the last two recommendations with a view more link if there are more than two: image

understood, I'll redesign the recommendations field

@tsu-ki
Copy link
Contributor Author

tsu-ki commented Mar 4, 2025

@DonnieBLT sir, can you please review this implementation? should I make any other changes to it, thank you

Screen.Recording.2025-03-04.at.6.36.13.PM.mov

@tsu-ki tsu-ki requested a review from DonnieBLT March 4, 2025 16:23
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
@tsu-ki
Copy link
Contributor Author

tsu-ki commented Mar 6, 2025

@DonnieBLT sir, please review the changes as well as the attached video which shows the functionality and UI, if there's any changes required then please do let me know, thank you!

@tsu-ki tsu-ki removed their assignment Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add recommendations to allow for users to recommend others on their profile
2 participants