Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added allauth base template #3931

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

priyankaChauhan2804
Copy link

@priyankaChauhan2804 priyankaChauhan2804 commented Mar 13, 2025

User description

closes #3415

Description: This update includes the base template for Django AllAuth under the template folder, ensuring a consistent layout for authentication-related pages. The base template provides a structured foundation for login, signup, and other authentication views.


PR Type

Enhancement, Bug fix


Description

  • Introduced a new auth_base.html template for consistent authentication page layouts.

  • Updated login.html, logout.html, and signup.html to extend auth_base.html.

  • Added customizable blocks in auth_base.html for titles, descriptions, forms, and footers.

  • Improved maintainability and consistency of authentication-related templates.


Changes walkthrough 📝

Relevant files
Enhancement
login.html
Updated login page to use `auth_base.html`                             

website/templates/account/login.html

  • Changed base template from base.html to auth_base.html.
  • Ensures consistent layout for the login page.
  • +1/-1     
    logout.html
    Updated logout page to use `auth_base.html`                           

    website/templates/account/logout.html

  • Changed base template from base.html to auth_base.html.
  • Ensures consistent layout for the logout page.
  • +1/-1     
    signup.html
    Updated signup page to use `auth_base.html`                           

    website/templates/account/signup.html

  • Changed base template from base.html to auth_base.html.
  • Ensures consistent layout for the signup page.
  • +1/-1     
    auth_base.html
    Added new `auth_base.html` template                                           

    website/templates/auth_base.html

  • Added a new base template for authentication pages.
  • Includes customizable blocks for titles, descriptions, forms, and
    footers.
  • Provides a consistent structure for authentication-related templates.
  • +30/-0   

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    3415 - Partially compliant

    Compliant requirements:

    • Add a base template for Django AllAuth pages to ensure consistent layout across authentication-related pages.
    • Ensure the base template is used by all relevant AllAuth templates, such as login, logout, and signup.
    • Provide customizable blocks for titles, descriptions, forms, and footers in the base template.

    Non-compliant requirements:

    []

    Requires further human verification:

    []

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Styling Placeholder

    The CSS styles in the auth_base.html template are currently placeholders (/* Your styles here */). Ensure that this is intentional and that the final styles will be added or handled elsewhere.

    <style>
        .auth-container {
            /* Your styles here */

    Copy link
    Contributor

    PR Code Suggestions ✨

    @@ -0,0 +1,30 @@
    {% extends "base.html" %}
    {% load static %}
    {% load i18n %}
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We are no longer using styles, only tailwind

    Copy link
    Collaborator

    @DonnieBLT DonnieBLT left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Please remove and style tags and use tailwind. Would you also show a screenshot of the forgot password page?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    fix all the allauth pages
    2 participants