Updated user details page #1176
Conversation
Summary by CodeRabbit
WalkthroughThis pull request adds support for including detailed pull request author information to both the backend GraphQL schema and the frontend presentation. The "author" field is exposed in the pull request node on the backend. On the frontend, the GraphQL query, data types, component rendering, and associated tests were updated to include and display the author details for recent pull requests, along with a separate section for recent releases. Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used🧬 Code Definitions (1)frontend/src/pages/Home.tsx (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (14)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/__tests__/unit/data/mockHomeData.ts (1)
82-101: Mock data covers different author scenarios, but uses future dates.The mock data provides good test coverage by including two different author scenarios (one with name, one with login), but the dates are set in the future (March 2025).
Consider changing the dates to past dates for more realistic test data:
- createdAt: '2025-03-25T10:00:00Z', + createdAt: '2023-03-25T10:00:00Z',- createdAt: '2025-03-24T15:30:00Z', + createdAt: '2023-03-24T15:30:00Z',frontend/src/components/ItemCardList.tsx (1)
35-46: Consider handling missing author login for profile links.The component links to the author's profile using
item?.author?.login, but your mock data shows some authors might have a name but no login property, which could result in broken links.Consider adding a conditional to only render the link when login is available:
{showAvatar && item?.author?.login ? ( <a className="flex-shrink-0 text-blue-400 hover:underline dark:text-blue-200" href={`/community/users/${item.author.login}`} > <img src={item?.author?.avatarUrl} alt={item?.author?.name} className="mr-2 h-6 w-6 rounded-full" /> </a> ) : showAvatar && ( <img src={item?.author?.avatarUrl} alt={item?.author?.name} className="mr-2 h-6 w-6 rounded-full" /> )}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
backend/apps/github/graphql/nodes/pull_request.py(1 hunks)frontend/__tests__/unit/data/mockHomeData.ts(1 hunks)frontend/__tests__/unit/pages/Home.test.tsx(1 hunks)frontend/src/api/queries/homeQueries.ts(1 hunks)frontend/src/components/ItemCardList.tsx(1 hunks)frontend/src/pages/Home.tsx(1 hunks)frontend/src/types/home.ts(2 hunks)
🧰 Additional context used
🧬 Code Definitions (2)
frontend/src/pages/Home.tsx (1)
frontend/src/utils/dateFormatter.ts (1)
formatDate(1-16)
frontend/__tests__/unit/pages/Home.test.tsx (2)
frontend/src/pages/Home.tsx (1)
Home(35-399)frontend/__tests__/unit/data/mockHomeData.ts (1)
mockGraphQLData(1-102)
🔇 Additional comments (9)
backend/apps/github/graphql/nodes/pull_request.py (1)
19-19: LGTM! Author field added to GraphQL schema.The addition of the "author" field to the PullRequestNode's fields tuple is clean and follows the existing pattern. This change properly exposes the author information through the GraphQL API, which aligns with the frontend changes.
frontend/src/api/queries/homeQueries.ts (1)
57-66: LGTM! Well-structured query for recent pull requests.The implementation follows the same pattern as other "recent" queries with appropriate fields and limiting to 5 items. The author fields match what's being exposed from the backend and align with the UI requirements.
frontend/src/components/ItemCardList.tsx (1)
21-25: LGTM! Author type definition added correctly.The author property has been added to the type definition with the appropriate fields matching the GraphQL schema.
frontend/src/types/home.ts (2)
10-10: Addition of recentPullRequests property looks goodThe new property is well-typed and follows the existing pattern of other array properties in the MainPageData type.
50-59: Well-structured PullRequestsType definitionThe new PullRequestsType includes all necessary fields for displaying pull request information, including the author details. The structure is consistent with other types in this file.
frontend/__tests__/unit/pages/Home.test.tsx (1)
170-182: Test for Recent Pull Requests section is comprehensiveGreat job adding a test that verifies both the section title and the individual pull request details, including author information. The test correctly checks for either the author's name or login, which matches the conditional rendering in the Home component.
frontend/src/pages/Home.tsx (3)
272-274: Good implementation of the Recent Pull Requests listThe update from "Recent Releases" to "Recent Pull Requests" in the ItemCardList is well-implemented, with the correct data source.
277-283: Nice addition of author informationThe conditional rendering of author information is well-implemented, showing either the name or login if available. The icon addition provides good visual context.
288-334: Well-structured Recent Releases sectionThe new SecondaryCard implementation for Recent Releases is well-designed:
- Proper conditional rendering based on data availability
- Clean layout with consistent styling
- Good use of icons and formatting for dates
- Author information is displayed prominently with avatar
This provides a much better presentation than the previous implementation.
|
* Updated user details page * Added Pull requests to homepage * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
Fixes: #1160