Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ChineseTranslation #1002

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Conversation

Soumyaditya25
Copy link
Contributor

Checklist

I have followed the Contributor Guidelines.
The code has been thoroughly tested in my local development environment with flake8 and pylint.
The code is Python 3 compatible.
The code follows the PEP8 styling guidelines with 4 spaces indentation.
This Pull Request relates to only one issue or only one feature
I have referenced the corresponding issue number in my commit message
I have added the relevant documentation.
My branch is up-to-date with the Upstream master branch.
Added Chinese translations for scan comparison (issue: #905 )

Changes proposed in this pull request:

Added Chinese translations for the zh-cn.yaml localization file.
Resolves issue #905.

[x ] Localization improvement

[x ] I've followed the [contributing guidelines]

[x ] I've run make pre-commit, it didn't generate any changes

[x ] I've run make test, all tests passed locally

@Soumyaditya25
Copy link
Contributor Author

Hi @securestep9 ,I’ve been working on this translation and have thoroughly reviewed it multiple times to ensure accuracy. Could you please review the PR when you get a chance? Let me know if any changes are needed.
Thanks for your time!

@securestep9
Copy link
Collaborator

allow me some time to review, as I am contacting a native Chinese friend to validate

@securestep9 securestep9 self-assigned this Feb 11, 2025
Copy link
Collaborator

@securestep9 securestep9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution @Soumyaditya25 !

@securestep9 securestep9 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into OWASP:master with commit 012bf5d Feb 14, 2025
17 checks passed
@Soumyaditya25 Soumyaditya25 deleted the Cntranslation branch March 5, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants