Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented HTTP client test suite using unittest with 79% coverage #1050

Closed
wants to merge 4 commits into from

Conversation

Ani07-05
Copy link

Proposed change

Added HTTP testing suite in test_http.py covering:

  • HTTP request/response handling
  • Session management
  • Response conditions
  • Error scenarios
  • HTTP engine functionality

Type of change

  • New core framework functionality
  • Bugfix (non-breaking change which fixes an issue)
  • Code refactoring without any functionality changes
  • New or existing module/payload change
  • Localization improvement
  • Dependency upgrade
  • Documentation improvement

Checklist

  • I've followed the [contributing guidelines][contributing-guidelines]
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@Ani07-05
Copy link
Author

@pUrGe12 closed my previous PR , please review this and let me know

Copy link
Contributor

@pUrGe12 pUrGe12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have added your poetry installs in here (eg. pytest version change, virtualenv, identify). I would suggest not doing this and making a PR only for the test.

@Ani07-05
Copy link
Author

Ani07-05 commented Apr 4, 2025

I think you have added your poetry installs in here (eg. pytest version change, virtualenv, identify). I would suggest not doing this and making a PR only for the test.

so do I add poetry-lock to gitignore and only create a new PR for test_http.py

@Ani07-05
Copy link
Author

Ani07-05 commented Apr 5, 2025

I think you have added your poetry installs in here (eg. pytest version change, virtualenv, identify). I would suggest not doing this and making a PR only for the test.

I'll make a PR only for the test then thank you

@Ani07-05 Ani07-05 closed this Apr 5, 2025
@Ani07-05 Ani07-05 reopened this Apr 5, 2025
Signed-off-by: Anirudh <[email protected]>
@Ani07-05 Ani07-05 closed this Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants