Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python313 support #1055

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gitbibekmishra
Copy link

Description

Fixes #986 by enabling Python 3.13.1 support through:

  • Removal of Python version constraints
  • Conditional dependency management (asyncssh/paramiko)
  • CI/CD updates for 3.13 testing

Test Results

Platform Status Notes
Ubuntu 22.04 ✅ Pass Python 3.13.1 + asyncssh
Windows 11 ✅ Pass WSL2
macOS Ventura ✅ Pass Homebrew Python

Checklist

  • Updated pyproject.toml
  • Added compatibility layer (core/test_compat.py)
  • Verified backward compatibility (Python 3.9-3.12)
  • Updated CI/CD workflows

cc @OWASP/Nettacker-maintainers @q2dg (issue reporter)

@gitbibekmishra
Copy link
Author

Hi @arkid15r and @securestep9, I’ve implemented Python 3.13.1 support, ensuring compatibility by updating dependencies, adding a compatibility layer, and modifying CI/CD workflows. All tests have passed across multiple platforms, and backward compatibility (Python 3.9-3.12) has been verified. Please take a look when you have time—let me know if you have any feedback or if any changes are needed. Thanks!

Copy link
Collaborator

@securestep9 securestep9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitbibekmishra very messy PR will lots of unrelated files and unnecessary formatting changes like extra line breaks all over the place which do not provide any Python v3.13 compatibility functionality - looks like you just dumped your working folder along with temporary files, report files and unrelated files into a PR. Please clean it up and submit in a clean PR with which contains only the necessary code modifications to achieve the issue you are trying to fix, avoiding unrelated changes.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitbibekmishra what is this broken file ? How is it related to Python 3.13 issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting changes are unrelated to the claimed purpose of the PR and should not be mixed with other changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are pycache files which should never be committed into git repo. Check your .gitignore before submitting PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install Nettacker if Python interpreter is 3.13.1
2 participants