Fixed README with installation instructions for Docker and fixed MySQL errors due to SQLite default #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
nettacker-nettacker-1
tonettacker
in the second command.This was because when I tried running it locally on a new machine, I got the following error:
Error response from daemon: No such container: nettacker-nettacker-1
Hence, the change.
Fixed MySQL errors fixing MySQL connections fail due to SQLite specific config in DbConfig #999 and MySQL not working #555
Corrected MySQL server name using pymysql.
Updated docstring for DbConfig class for MySQL related parameters
Corrected
db.py
file to include pymysql, change arguments based on engine name and improvedremove_old_logs
function with pymysql required changes.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locallyAdditional comments:
pip install pymysql
SET GLOBAL max_connections = 1000;
[contributing-guidelines]: https://nettacker.readthedocs.io/en/latest/Developers/