Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive change to use of locations and calculation of production volumes #154

Merged
merged 48 commits into from
Dec 19, 2018

Conversation

cmutel
Copy link
Member

@cmutel cmutel commented Dec 19, 2018

Highlights:

  • Links market groups
  • RoW is now resolved in space for both consumers and suppliers
  • Added constructive_geometries as base source of data
  • Track both gross and net production volumes or markets and transforming activities

Fixes #20, #149, #143, #100, and #92.

Note that there are still serious questions with how the release version of ecoinvent actually works, including #147 and #140.

Before merging, need to add the following validation and logging functions: #131, #148, #150, #151.

This isn't the right answer, though. i) It substitutes market groups even if they are smaller than the original linked market ii) It doesn't substitute multiple markets at once.
@coveralls
Copy link

coveralls commented Dec 19, 2018

Coverage Status

Coverage increased (+0.05%) to 86.928% when pulling 9d11684 on market_groups into 7e80484 on master.

@cmutel
Copy link
Member Author

cmutel commented Dec 19, 2018

Also fixes #140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cutoff function 10: RemoveDatasets(MarketWithZeroProductionVolumeFilter)
2 participants