Fix comment for bit list explanation#58
Open
mitmotw wants to merge 1 commit intoOffchainLabs:masterfrom
Open
Conversation
|
|
prestonvanloon
approved these changes
Aug 7, 2023
Member
prestonvanloon
left a comment
prestonvanloon
left a comment
There was a problem hiding this comment.
Nice catch. This looks good to me.
Tested here: https://go.dev/play/p/ijzr7bz8QBs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understood based on the other functions like BitAt or SetBitAt,
9th bit (with index 8) is the right most bit in the 2nd byte.
So in below byte array,
byte{0b00011000, 0b00000010}
this byte array indicates bitlist with 9 bits and
the rightmost bit in the 2nd byte is the final bit with index 8 like below.
bits=[0,0,0,1,1,0,0,0,0]