Skip to content

Constraint based pricing gas dimension trace tests #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

relyt29
Copy link
Collaborator

@relyt29 relyt29 commented May 13, 2025

This PR adds tests to the contracts repo that are used in abigen/solgen in nitro to do system_tests of multidimensional gas tracking. This work is related to OffchainLabs/nitro#3233 and OffchainLabs/go-ethereum#459.

None of this code is related to the other contracts in this repo, and all of the solidity is only test solidity, not intended to be used outside of integration testing. The code is isolated into the gas-dimensions folder, and I added a foundry build target separate from the rest of the code (which is also necessary because this code will not compile with the yul optimizer set to on).

The main nitro repo can then call the new yarn build command in the package.json to compile the test contracts, and will add the compiled test contracts into the solgen folder in the nitro repo.

the scripts should also still be runnable using forge script so long as you pass the profile correctly e.g. something like

./target/bin/nitro --dev;
FOUNDRY_PROFILE=gas-dimensions forge script gas-dimensions/script/Sstore.s.sol -vvvvv --private-key "nitro --dev environment private key here" --slow --broadcast --rpc-url http://127.0.0.1:8547 --priority-gas-price "1000000000" --with-gas-price "2000000000" -g "10000"  --chain-id "412346"

This PR is a duplicate of #344 and replaces it.

@relyt29 relyt29 self-assigned this May 13, 2025
Copy link

cla-bot bot commented May 13, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@hkalodner
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the s label May 13, 2025
Copy link

cla-bot bot commented May 13, 2025

The cla-bot has been summoned, and re-checked this pull request!

@relyt29 relyt29 force-pushed the gas-dimension-test-contracts branch from fb051b2 to 241be74 Compare May 13, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants