redis pubsub: add retries limit and option to disable retries #2803
+250
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicxyyz
force-pushed
the
pubsub-max-retry-count
branch
from
cf0c3a5 to
f8db4cf
Compare
cla-bot
bot
added
the
s
ganeshvanahalli
previously approved these changes
Apr 14, 2025
ganeshvanahalli
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-2815
This PR adds two new redis pubsub consumer configs:
retry- enables autoclaim for this consumer, if set to false this consumer will not check messages from PEL (Pending Entries List)max-retry-count- number of message retries after which this consumer will set an error response and Acknowledge the message (-1 = no limit)Those configs are designed with validator workers in mind.
idletime-to-autoclaim- in case processing of those messages failed due to OOM.max-retry-countis not-1, any consumer withretryflag set will not retry messages already retried more thenmax-retry-counttimes, instead it will try to set an error response for the message and acknowledge it as processed.