Skip to content

Paralellise in builder [Draft] #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+202 −181
Draft

Paralellise in builder [Draft] #2992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28389f6
Paralellise in builder: Initial
tsahee Mar 5, 2025
1eb87a1
dont paralelise challenges
tsahee Mar 5, 2025
bcccf12
separate the two testEarlyExit tests
tsahee Mar 5, 2025
841f758
more fixes
tsahee Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion system_tests/aliasing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import (
)

func TestAliasing(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

Expand Down
3 changes: 0 additions & 3 deletions system_tests/ancients_finalized_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ func generateBlocks(t *testing.T, ctx context.Context, builder *NodeBuilder, tes
}

func TestFinalizedBlocksMovedToAncients(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down Expand Up @@ -92,7 +91,6 @@ func TestFinalizedBlocksMovedToAncients(t *testing.T) {
}

func TestFinalityDataWaitForBlockValidator(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down Expand Up @@ -177,7 +175,6 @@ func TestFinalityDataWaitForBlockValidator(t *testing.T) {
}

func TestFinalityDataPushedFromConsensusToExecution(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down
2 changes: 0 additions & 2 deletions system_tests/arbos_upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ func checkArbOSVersion(t *testing.T, testClient *TestClient, expectedVersion uin
}

func TestArbos11To32UpgradeWithMcopy(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down Expand Up @@ -187,7 +186,6 @@ func TestArbos11To32UpgradeWithMcopy(t *testing.T) {
}

func TestArbos11To32UpgradeWithCalldata(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down
2 changes: 0 additions & 2 deletions system_tests/batch_poster_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ func testBatchPosterParallel(t *testing.T, useRedis bool) {
}

func TestBatchPosterLargeTx(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

Expand Down Expand Up @@ -281,7 +280,6 @@ func TestBatchPosterKeepsUp(t *testing.T) {
}

func testAllowPostingFirstBatchWhenSequencerMessageCountMismatch(t *testing.T, enabled bool) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

Expand Down
1 change: 0 additions & 1 deletion system_tests/block_validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ type Options struct {
}

func testBlockValidatorSimple(t *testing.T, opts Options) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

Expand Down
1 change: 0 additions & 1 deletion system_tests/bloom_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
)

func TestBloom(t *testing.T) {
t.Parallel()
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
builder := NewNodeBuilder(ctx).DefaultConfig(t, false)
Expand Down
4 changes: 1 addition & 3 deletions system_tests/bold_state_provider_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ import (
)

func TestChallengeProtocolBOLD_Bisections(t *testing.T) {
t.Parallel()
ctx, cancelCtx := context.WithCancel(context.Background())
defer cancelCtx()
l2node, l1info, l2info, l1stack, l1client, stateManager, blockValidator := setupBoldStateProvider(t, ctx, 1<<5)
Expand Down Expand Up @@ -156,8 +155,7 @@ func TestChallengeProtocolBOLD_Bisections(t *testing.T) {
}

func TestChallengeProtocolBOLD_StateProvider(t *testing.T) {
// t.Parallel()
ctx, cancelCtx := context.WithCancel(context.Background())
// ctx, cancelCtx := context.WithCancel(context.Background())
defer cancelCtx()
maxNumBlocks := uint64(1 << 14)
l2node, l1info, l2info, l1stack, l1client, stateManager, blockValidator := setupBoldStateProvider(t, ctx, maxNumBlocks)
Expand Down
1 change: 0 additions & 1 deletion system_tests/classic_redirect_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
)

func TestClassicRedirectURLNotLeaked(t *testing.T) {
t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down
Loading
Loading