Ajay's Sample Health Check-Up And Fixes #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawank-MSFT
reviewed
Dec 27, 2024
samples/bot-type-ahead-search-adaptive-cards/csharp/TeamsApp/appPackage/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Copilot reviewed 9 out of 24 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- samples/app-complete-auth/nodejs/views/config.ejs: Language not supported
- samples/app-link-unfurling-in-share-to-teams/csharp/LinkUnfurlingInShareToTeams/appsettings.json: Language not supported
- samples/bot-type-ahead-search-adaptive-cards/csharp/TeamsApp/appPackage/manifest.json: Language not supported
- samples/bot-type-ahead-search-adaptive-cards/csharp/TypeaheadSearch/Cards/DependentDropdown.json: Language not supported
- samples/tab-deeplink/csharp/DeepLinkBot/appsettings.json: Language not supported
- samples/app-complete-auth/csharp/AppCompleteAuth/Pages/config.cshtml: Evaluated as low risk
- samples/tab-stage-view/csharp/TabInStageView/Bots/ActivityBot.cs: Evaluated as low risk
- samples/app-complete-auth/nodejs/bots/teamsBot.js: Evaluated as low risk
- samples/app-installation-using-qr-code/csharp/README.md: Evaluated as low risk
- samples/tab-stage-view/csharp/TeamsApp/teamsapp.local.yml: Evaluated as low risk
- samples/tab-stage-view/csharp/TabInStageView/Controllers/HomeController.cs: Evaluated as low risk
- samples/tab-deeplink/nodejs/teamsapp.local.yml: Evaluated as low risk
- samples/tab-deeplink/csharp/DeepLinkBot/Bots/DeepLinkBot.cs: Evaluated as low risk
- samples/tab-deeplink/nodejs/Bots/DeepLinkTabsnode.js: Evaluated as low risk
- samples/app-link-unfurling-in-share-to-teams/csharp/TeamsApp/teamsapp.local.yml: Evaluated as low risk
| @@ -24,7 +24,7 @@ public class ActivityBot : TeamsActivityHandler | |||
| public ActivityBot(IConfiguration configuration) | |||
| { | |||
| _applicationBaseUrl = configuration["ApplicationBaseUrl"] ?? throw new NullReferenceException("ApplicationBaseUrl"); | |||
| _microsoftAppId= configuration["MicrosoftAppId"] ?? throw new NullReferenceException("MicrosoftAppId"); | |||
| _microsoftAppId= configuration["TeamsAppId"] ?? throw new NullReferenceException("MicrosoftAppId"); | |||
There was a problem hiding this comment.
The error message should be updated to reflect the new configuration key 'TeamsAppId'.
Suggested change
| _microsoftAppId= configuration["TeamsAppId"] ?? throw new NullReferenceException("MicrosoftAppId"); | |
| _microsoftAppId= configuration["TeamsAppId"] ?? throw new NullReferenceException("TeamsAppId"); |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Pawank-MSFT
approved these changes
Dec 27, 2024
Pawank-MSFT
reviewed
Jan 2, 2025
|
|
||
| The simplest way to run this sample in Teams is to use Teams Toolkit for Visual Studio. | ||
| 1. Install Visual Studio 2022 **Version 17.10 Preview 4 or higher** [Visual Studio](https://visualstudio.microsoft.com/downloads/) | ||
| 1. Install Teams Toolkit for Visual Studio [Teams Toolkit extension](https://learn.microsoft.com/en-us/microsoftteams/platform/toolkit/toolkit-v4/install-teams-toolkit-vs?pivots=visual-studio-v17-7) |
There was a problem hiding this comment.
Why we have removed this?
|
Executed build pipeline: 
|
Harikrishnan-MSFT
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samples List
1.app-complete-auth
2.app-installation-using-qr-code
3.app-link-unfurling-in-share-to-teams
4.bot-conversartion
5.bot-type-ahead-search-adaptive-cards
6.graph-appcatalog-lifecycle
7.tab-deeplink
8.tab-stage-view