Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Bot-Task-Module Sample with Tab Navigation Using Adaptive C… #1537

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

Harikrishnan-MSFT
Copy link
Contributor

…ards in Microsoft Teams (Node.js and C#)

@Pawank-MSFT Pawank-MSFT requested a review from Copilot January 30, 2025 11:21
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

samples/bot-task-module/csharp/Pages/Tasks.cshtml:2

  • Missing semicolon at the end of the line.
@using Microsoft.Teams.Samples.TaskModule.Web.Helper

samples/bot-task-module/csharp/Pages/Shared/_Layout.cshtml:12

  • There is an extra closing script tag that should be removed.
</script>

@@ -9,14 +9,16 @@
}

@{
@*Passing BaseUrl and MicrosoftAppId to DeepLnkHelper as a parameter*@
DeeplinkHelper deepLinkHelper = new DeeplinkHelper(@Json.Serialize(Configuration["MicrosoftAppId"]).ToString(), @Json.Serialize(Configuration["BaseUrl"]).ToString());
// Passing BaseUrl and MicrosoftAppId to DeepLnkHelper as a parameter
Copy link
Preview

Copilot AI Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should refer to 'DeeplinkHelper' instead of 'DeepLnkHelper'.

Suggested change
// Passing BaseUrl and MicrosoftAppId to DeepLnkHelper as a parameter
// Passing BaseUrl and MicrosoftAppId to DeeplinkHelper as a parameter

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, Approving!

@Pawank-MSFT
Copy link
Collaborator

Pawank-MSFT commented Jan 31, 2025

Copy link
Contributor

@Jegadeesh-MSFT Jegadeesh-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Copy link
Collaborator

@Pawank-MSFT Pawank-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct, Approving!

@Pawank-MSFT Pawank-MSFT merged commit 638df3d into main Jan 31, 2025
274 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants