Sample Migration Bot People Picker Adaptive Card To Python #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 18 out of 33 changed files in this pull request and generated 3 comments.
Files not reviewed (15)
- samples/bot-people-picker-adaptive-card/python/.env: Language not supported
- samples/bot-people-picker-adaptive-card/python/.gitignore: Language not supported
- samples/bot-people-picker-adaptive-card/python/.vscode/extensions.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/.vscode/launch.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/.vscode/settings.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/.vscode/tasks.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/appManifest/manifest.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/assets/sample.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/env/.env.local: Language not supported
- samples/bot-people-picker-adaptive-card/python/infra/azure.bicep: Language not supported
- samples/bot-people-picker-adaptive-card/python/infra/azure.parameters.json: Language not supported
- samples/bot-people-picker-adaptive-card/python/requirements.txt: Language not supported
- samples/bot-people-picker-adaptive-card/python/bots/init.py: Evaluated as low risk
- samples/bot-people-picker-adaptive-card/python/adaptive_cards/cards.py: Evaluated as low risk
- samples/bot-people-picker-adaptive-card/python/config.py: Evaluated as low risk
| > the Teams service needs to call into the bot. | ||
|
|
||
| 1) Setup for Bot | ||
| - In Azure portal, create Microsoft Entra ID app registraion and it will generate MicrosoftAppId and MicrosoftAppPassword for you. |
There was a problem hiding this comment.
The word 'registraion' should be corrected to 'registration'.
Suggested change
| - In Azure portal, create Microsoft Entra ID app registraion and it will generate MicrosoftAppId and MicrosoftAppPassword for you. | |
| - In Azure portal, create Microsoft Entra ID app registration and it will generate MicrosoftAppId and MicrosoftAppPassword for you. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
|
||
| async def on_teams_members_added( | ||
| self, | ||
| teams_members_added: [TeamsChannelAccount], |
There was a problem hiding this comment.
The type hint for teams_members_added should use List from the typing module. Change it to teams_members_added: List[TeamsChannelAccount].
Suggested change
| teams_members_added: [TeamsChannelAccount], | |
| teams_members_added: List[TeamsChannelAccount], |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| - Extracts the text of the mention and removes it from the activity's text. | ||
| - Strips extra spaces after removing the mention. | ||
| """ | ||
| if activity.entities and activity.entities[0].type == "mention": |
There was a problem hiding this comment.
The remove_mention_text method only handles the first mention entity. It should be updated to handle multiple mentions.
Suggested change
| if activity.entities and activity.entities[0].type == "mention": | |
| if activity.entities: |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Pawank-MSFT
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.