feat: a11y Keyboard Navigation for Modals#624
Merged
Conversation
|
@Salmatcre8 is attempting to deploy a commit to the Stephen's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Salmatcre8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
cd8fac9 to
0a14c6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #525
Description
This PR implements robust keyboard accessibility for modals by introducing a global
useFocusTraphook, ensuring users who navigate with keyboards cannot accidentally tab outside the modal context.Changes Included
useFocusTrapHook: InterceptsTabandShift+Tabkeystrokes to cycle focus purely between the first and last interactive elements within a modal container.Escapekey directly within the focus trap hook, removing the need for duplicate logic across different components.role="dialog"andaria-modal="true"toConfirmDialogandTransactionConfirmModalfor improved screen-reader announcement.(Note:
TransactionDetailModal.tsxwas excluded as it did not exist in the codebase).