feat: a11y Form Field Labels and Descriptions#625
Merged
Conversation
|
@Salmatcre8 is attempting to deploy a commit to the Stephen's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Salmatcre8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Salmatcre8
force-pushed
the
issue-526-a11y-forms
branch
from
541f897 to
8a0aa1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #526
Description
This PR addresses accessibility issues in the core escrow flow by ensuring all input fields are properly described to screen readers using
aria-describedbyandaria-invalid.Changes Included
CreateEscrowForm,RoommateInput, andContributeFormare already correctly linked to<label>tags via thehtmlForandidpattern.idto the "Ledger timestamp" display in the Escrow setup form and linked it to theDateInput.idto the calculated percentage display inRoommateInputand appended it to the input'saria-describedbychain.ContributeForm.