ZigRazor#486 Addresses review comments

OlekRaymond · Jan 7, 2025 · 0956d94 · 0956d94
1 parent de1b863
commit 0956d94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -36,6 +36,9 @@ jobs:
     - name: Configure CMake
       # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
       # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
+
+      # The macro ${{github.workspace}} results in windows file seprators, (\) which CMake often cannot parse. 
+      # To get around this use a relative path instead.
       run: |
         if [ ${{ matrix.os }} == 'windows-latest' ]; then
           cmake -DTEST=ON -Dgtest_disable_pthreads=ON -B ./build

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -31,7 +31,7 @@ if (NOT MSVC)
 			-fsanitize=leak
 		)
 	endif(SANITIZE)
-endif()
+endif(NOT MSVC)
 
 # set up CPM.cmake
 if(CPM_SOURCE_CACHE)

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -23,7 +23,7 @@ if (NOT MSVC)
         )
 
     endif(CODE_COVERAGE)
-endif()
+endif(NOT MSVC)
 
 option(TEST "Enable Test" OFF)
 if(TEST)
@@ -33,7 +33,7 @@ if(TEST)
         -Wall
         -Wextra
         )
-    endif()
+    endif(NOT MSVC)
 
     CPMAddPackage(
         NAME googletest