Skip to content

fix: address display in btc only firmware #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

Lu1zz
Copy link
Contributor

@Lu1zz Lu1zz commented Mar 31, 2025

Summary by CodeRabbit

  • Refactor
    • Improved the logic for determining and displaying addresses based on the active configuration, ensuring more reliable and maintainable address generation.

@Lu1zz Lu1zz requested a review from a team as a code owner March 31, 2025 07:36
Copy link

coderabbitai bot commented Mar 31, 2025

Walkthrough

The change adds a conditional structure in the generate_address method. It assigns the address from address_resp.address when utils.BITCOIN_ONLY is true. Otherwise, it checks the msg_type of chain_info to determine whether to use address_resp.address or address_resp.npub. No public interface declarations were modified.

Changes

File Change Summary
core/src/trezor/.../address.py Updated generate_address method to replace the inline conditional assignment with a structured conditional block that chooses the address based on flags.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between da4372e and c4d2080.

📒 Files selected for processing (1)
  • core/src/trezor/lvglui/scrs/address.py (1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
core/src/trezor/lvglui/scrs/address.py (4)
core/src/trezor/enums/__init__.py (1)
  • MessageType (23-443)
python/src/trezorlib/messages.py (2)
  • MessageType (31-451)
  • NostrGetPublicKey (9443-9457)
core/src/trezor/messages.py (1)
  • NostrGetPublicKey (7463-7477)
core/src/trezor/ui/layouts/lvgl/__init__.py (1)
  • show_address_offline (355-414)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Gen check
  • GitHub Check: Defs check
  • GitHub Check: Style check
🔇 Additional comments (1)
core/src/trezor/lvglui/scrs/address.py (1)

716-724: Improved address handling for Bitcoin-only firmware.

The change properly addresses the issue with display in Bitcoin-only firmware by using a clear condition structure.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Lu1zz Lu1zz merged commit a989222 into OneKeyHQ:main Mar 31, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants